Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): add user defined topic dimension consumer limiter #895

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Aug 18, 2022

What is the purpose of the change

Add user defined consume rate limiter which is topic dimension. The user could use self defined Limiter 'block' consume to controller topic consume rate based on TPS / Concurrent / Load or any other condition.

Brief changelog

  • add consumer Limiter func definition.
  • add Limiter to push_consumer#consumeMessageCurrently

#896

@superhx superhx closed this Aug 18, 2022
@superhx superhx reopened this Aug 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #895 (9ef0fd5) into master (1c75f23) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
- Coverage   23.81%   23.73%   -0.09%     
==========================================
  Files          52       52              
  Lines        7105     7129      +24     
==========================================
  Hits         1692     1692              
- Misses       5187     5211      +24     
  Partials      226      226              
Impacted Files Coverage Δ
consumer/option.go 20.33% <0.00%> (-0.54%) ⬇️
consumer/push_consumer.go 12.78% <0.00%> (-0.11%) ⬇️
internal/utils/namespace.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShannonDing ShannonDing merged commit 2e1b335 into apache:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants