Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #901]Close the traceDispatcher when producer or consumer is shutdown #902

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

zhangjidi2016
Copy link
Contributor

What is the purpose of the change

#901

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #902 (c8eec1a) into master (c9ca891) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   23.69%   23.64%   -0.05%     
==========================================
  Files          52       52              
  Lines        7142     7146       +4     
==========================================
- Hits         1692     1690       -2     
- Misses       5224     5228       +4     
- Partials      226      228       +2     
Impacted Files Coverage Δ
consumer/interceptor.go 0.00% <0.00%> (ø)
consumer/option.go 19.83% <ø> (ø)
consumer/push_consumer.go 12.65% <0.00%> (-0.13%) ⬇️
producer/interceptor.go 0.00% <0.00%> (ø)
producer/option.go 38.70% <ø> (ø)
producer/producer.go 28.07% <0.00%> (-0.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShannonDing ShannonDing linked an issue Aug 24, 2022 that may be closed by this pull request
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 24, 2022
@ShannonDing ShannonDing merged commit 2630383 into apache:master Aug 24, 2022
@zongtanghu
Copy link

LGTM

@zhangjidi2016 zhangjidi2016 deleted the trace_close branch August 24, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close the traceDispatcher when producer or consumer is shutdown
4 participants