Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(producer) improve the transaction unit test stability #67

Merged
merged 1 commit into from Nov 4, 2019

Conversation

duhenglucky
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #67 into ctypes will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ctypes      #67      +/-   ##
==========================================
- Coverage   80.16%   79.15%   -1.01%     
==========================================
  Files           4        4              
  Lines         595      595              
==========================================
- Hits          477      471       -6     
- Misses        118      124       +6
Impacted Files Coverage Δ
rocketmq/client.py 62.85% <0%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5debfd0...78a41c8. Read the comment docs.

@duhenglucky duhenglucky merged commit 96ca920 into apache:ctypes Nov 4, 2019
@ShannonDing ShannonDing modified the milestones: 1.2.4, Python3.6, 2.0.0 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants