Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #708] Fix the issue that PushConsumer reentrant pop doesn't work as expected #709

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Mar 15, 2024

Which Issue(s) This PR Fixes

Fixes #708

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 47.18%. Comparing base (3036b04) to head (b13e272).

Files Patch % Lines
...mq/client/java/impl/consumer/ProcessQueueImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #709      +/-   ##
============================================
- Coverage     55.82%   47.18%   -8.64%     
  Complexity      651      651              
============================================
  Files           259      207      -52     
  Lines         15856    12385    -3471     
  Branches       4089     3737     -352     
============================================
- Hits           8851     5844    -3007     
+ Misses         6717     6253     -464     
  Partials        288      288              
Flag Coverage Δ
java 61.68% <0.00%> (ø)
nodejs ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@lizhanhui lizhanhui merged commit fe3805c into apache:master Mar 18, 2024
20 checks passed
@starhu521
Copy link

May I know when this fix will be released? This issue often occurs during network fluctuations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PushConsumer reentrant pop orderly doesn't work as expected
5 participants