Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] implement pushconsumer #767

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

glcrazier
Copy link
Contributor

@glcrazier glcrazier commented Jun 9, 2024

Which Issue(s) This PR Fixes

Fixes #683

Brief Description

This is an implementation of standard and fifo PushConsumer which can consumes messages with listener provided.

How Did You Test This Change?

Sufficient unit test cases are provided and integration tests are executed.

@lizhanhui
Copy link
Contributor

Thanks @glcrazier for your nice work and I would join you and review this promising feature ASAP.

@glcrazier glcrazier changed the title [rust] implement standard pushconsumer [rust] implement pushconsumer Jul 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 88.51208% with 271 lines in your changes missing coverage. Please review.

Project coverage is 83.37%. Comparing base (c8a685d) to head (2412a78).
Report is 6 commits behind head on master.

Files Patch % Lines
rust/src/push_consumer.rs 90.68% 72 Missing and 72 partials ⚠️
rust/src/client.rs 76.35% 58 Missing and 12 partials ⚠️
rust/src/session.rs 71.73% 26 Missing ⚠️
rust/src/conf.rs 92.43% 14 Missing and 4 partials ⚠️
rust/src/producer.rs 81.25% 2 Missing and 4 partials ⚠️
rust/src/util.rs 97.14% 1 Missing and 2 partials ⚠️
rust/src/model/message.rs 71.42% 0 Missing and 2 partials ⚠️
rust/src/model/common.rs 97.22% 1 Missing ⚠️
rust/src/simple_consumer.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #767       +/-   ##
=============================================
+ Coverage     47.43%   83.37%   +35.93%     
=============================================
  Files           207       13      -194     
  Lines         12384     5406     -6978     
  Branches       3736     5406     +1670     
=============================================
- Hits           5874     4507     -1367     
+ Misses         6221      698     -5523     
+ Partials        289      201       -88     
Flag Coverage Δ
cpp ?
golang ?
java ?
rust 83.37% <88.51%> (+3.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lizhanhui
lizhanhui previously approved these changes Aug 6, 2024
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
@lizhanhui
Copy link
Contributor

MSRV set to 1.61 does not make sense
run cargo msrv, we are having
image

Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
strategy:
matrix:
msrv: [1.61]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust version defined in Cargo.toml should be also bumped up to 1.70.0

Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement PushConsumer for Rust SDK
4 participants