[ISSUE #55]Delete the corresponding DLQ and Retry Topic simultaneously when deleting the consumerGroup. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neously when deleting the consumerGroup.
vongosling
requested changes
Jan 4, 2022
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
Outdated
Show resolved
Hide resolved
vongosling
requested changes
Jan 4, 2022
src/test/java/org/apache/rocketmq/dashboard/controller/ConsumerControllerTest.java
Show resolved
Hide resolved
StyleTang
reviewed
Jan 4, 2022
| String[] ns = configure.getNamesrvAddr().split(";"); | ||
| nameServerSet = new HashSet<>(Arrays.asList(ns)); | ||
| } | ||
| mqAdminExt.deleteTopicInNameServer(nameServerSet, topic); |
There was a problem hiding this comment.
Just want to confirm whether there is a problem with the deleteTopicInNameServer
A SubGroup can exist in multiple brokers.
For example :
GROUP_1
|----- brokerA
|------brokerB
If we just want to delete GROUP_1 in brokerA, deleteTopicInNameServer will also be invoked. It will delete all the QueueData of this topic in namesvr, not sure whether it will cause issue or not.
There was a problem hiding this comment.
Yes, that's a good question, I will fix it in next commit.
vongosling
requested changes
Jan 5, 2022
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
Show resolved
Hide resolved
vongosling
approved these changes
Jan 5, 2022
StyleTang
approved these changes
Jan 5, 2022
|
@zhangjidi2016 would you like to confirm why coverage drop a bit of coverage? We could fix it in the next pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#55
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.