Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature new metrics #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature new metrics #84

wants to merge 1 commit into from

Conversation

ArthurWrong
Copy link

  1. According to FLIP-33, I replace tpsMetric and outTps with numRecordsInPerSecond and numRecordsOutPerSecond, and replace their counter with numRecordsIn and numRecordsOut at the same time.
  2. Additionally, numRecordsIn, numRecordsOut, numRecordsInPerSecond, numRecordsOutPerSecond, these four metrics can be monitored on aliyun vvp.

@ArthurWrong ArthurWrong mentioned this pull request Mar 14, 2024
Open
@lizhimins
Copy link
Member

lizhimins commented Mar 27, 2024 •
edited

Thanks for your contributions! Can you rebase to last main branch.

@ArthurWrong ArthurWrong force-pushed the feature_new_metrics branch 3 times, most recently from 7f0a13a to d2278cf Compare March 28, 2024 09:48
@ArthurWrong
Copy link
Author

Thanks for your contributions! Can you rebase to last main branch.

Done.

@ArthurWrong ArthurWrong requested a review from humkum April 2, 2024 08:04
@ArthurWrong
Copy link
Author

@lizhimins @humkum Can we review the code and merge it into the main branch？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizhimins lizhimins lizhimins approved these changes

@humkum humkum Awaiting requested review from humkum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArthurWrong @lizhimins @humkum