Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when spring proxy bean will repeat name with "scopeTarget" bean to make some consumer #218

Closed
einsitang opened this issue Dec 30, 2019 · 2 comments
Closed

when spring proxy bean will repeat name with "scopeTarget" bean to make some consumer #218

einsitang opened this issue Dec 30, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@einsitang
Copy link
Contributor

einsitang commented Dec 30, 2019 •
edited
Loading

The issue tracker is ONLY used for bug report and feature request.

Any question or RocketMQ proposal please use our mailing lists.

BUG REPORT

when I use @RefreshScope( with alibaba nacos ) to make hot deploy properties features,rocketmq-spring will find some bean name with scopeTarget. , that will make some name for one bean,and register replace consumer with clientId like "IP@PID" , that is not work for rocketmq 4.6.0.

FEATURE REQUEST
filter bean without spring proxy

this fix on PR#210
@einsitang einsitang mentioned this issue Dec 30, 2019
Merged
@RongtongJin RongtongJin added the enhancement New feature or request label Dec 30, 2019
@RongtongJin RongtongJin added this to the 2.1.0 milestone Dec 30, 2019
@einsitang
Copy link
Contributor Author

@RongtongJin hello,any idea with this enhancement of next version deploy time ?

@RongtongJin
Copy link
Contributor

@forfuns RocketMQ-Spring 2.1.0 will release ASAP. It depends on when the pr are merged to master, especially the pr of request-reply.

RongtongJin pushed a commit that referenced this issue Feb 10, 2020
@forfuns @vongosling
[ISSUE #218] Fix spring scopeTarget will repeat consumer instance (#210)
2853384 
* change clientId algorithm

* code format

* develop

* optimize on 2.0.5.EINSITANG

* revert pom version

* change note

* change note

* revert demo.rocketmq.myNameServer

* remove clientInstaceName

* remove unuse method

* pass ci-check

* remove pass annotation

* correct variable word

* optimize annotation

* merge

Co-authored-by: von gosling <vongosling@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@einsitang @RongtongJin