Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to enable tls through configuration file #219

Closed
liuliuzo opened this issue Jan 6, 2020 · 4 comments · Fixed by #347
Closed

Support to enable tls through configuration file #219

liuliuzo opened this issue Jan 6, 2020 · 4 comments · Fixed by #347
Labels
discuss Discuss whether to support

Comments

@liuliuzo
Copy link
Contributor

liuliuzo commented Jan 6, 2020

这边因为规划问题出现了一个比较奇特的场景,应用客户端会连接MQ集群跨中心启用双向TLS。不跨中心的部分启用,部分不启用TLS。

(1) enable TLS for each Producer and Listener consumer

(2) support TLS by property file, current only JVM arguments can determines if client side use TLS jvm arg
tls.enable
tls.config.file

@RongtongJin RongtongJin added the discuss Discuss whether to support label Jan 6, 2020
@liuliuzo liuliuzo reopened this Feb 26, 2020
@liuliuzo liuliuzo changed the title need support TLS by springboot property file need support TLS Feb 26, 2020
@liuliuzo
Copy link
Contributor Author

liuliuzo commented May 4, 2020

这边因为规划问题出现了一个比较奇特的场景,应用客户端会连接MQ集群有的启用了TLS,有的没启用TLS。@RongtongJin consumer倒是可以prepareStart(),Producer same nameserver limitation虽然去除了但是还是希望能够增加一个producer enable TLS的选项。

@RongtongJin
Copy link
Contributor

@liuliuzo You can submit a pr to slove it, I can help review and merge.

liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jun 24, 2020
AsyncSenderExecutor in RocketMQTemplate.
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jun 30, 2020
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jun 30, 2020
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jun 30, 2020
@RongtongJin RongtongJin changed the title need support TLS Support to enable tls through configuration file Jul 16, 2020
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Sep 9, 2020
@liuliuzo
Copy link
Contributor Author

liuliuzo commented Sep 26, 2020

尴尬,由于没想到更优雅的方式,先把问题关闭先,目前项目里先讲究凑合的这么用着。

@ExtRocketMQTemplateConfiguration(nameServer = "${demo.rocketmq.extNameServer}")
public class RocketMQProducerLifecycleTemplate extends RocketMQTemplate implements RocketMQProducerLifecycle {

@Value("${samples.producer.useTLS}")
private boolean useTLS;

public void prepareStart(DefaultMQProducer producer) {
    producer.setUseTLS(useTLS);
}

}

@liuliuzo liuliuzo reopened this Jan 29, 2021
@liuliuzo
Copy link
Contributor Author

liuliuzo commented Jan 29, 2021

@RongtongJin 按照你的建议优化了下,重新打开这个问题重新提交了。

liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jan 29, 2021
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jan 29, 2021
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Jan 30, 2021
@liuliuzo liuliuzo closed this as completed Feb 5, 2021
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Feb 7, 2021
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Feb 7, 2021
@liuliuzo liuliuzo reopened this Feb 7, 2021
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Feb 15, 2021
@vongosling vongosling linked a pull request Sep 8, 2021 that will close this issue
3 tasks
vongosling added a commit that referenced this issue Sep 8, 2021
[ISSUE #219] Support to enable tls through configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discuss whether to support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants