Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer #206

Merged
merged 1 commit into from
Jan 2, 2020
Merged

[ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer #206

merged 1 commit into from
Jan 2, 2020

Conversation

zhangjidi2016
Copy link
Contributor

What is the purpose of the change

Fix the Infinite loop in DefaultRocketMQListenerContainer

Brief changelog

Adjust the getMessageType method

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zongtanghu
Copy link

I suggest this pr can be merged after December 31.

@vongosling
Copy link
Member

@zhangjidi2016 Great work, adding some related unit test for your pr could be convinced for a reviewer

@RongtongJin RongtongJin added the bug Something isn't working label Dec 24, 2019
@zhangjidi2016
Copy link
Contributor Author

@zhangjidi2016 Great work, adding some related unit test for your pr could be convinced for a reviewer

OK,The DefaultRocketMQListenerContainerTest class has already existed the unit test for getMessageType method, and has passed the unit test after submit this PR.

@vongosling vongosling added this to the 2.1.0 milestone Jan 2, 2020
@vongosling vongosling merged commit a86b8ef into apache:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants