Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate spring-configuration-metadata.json for easy configuration tips. #61

Merged
merged 1 commit into from May 8, 2019
Merged

Conversation

ChunMengLu
Copy link
Contributor

What is the purpose of the change

Generate spring-configuration-metadata.json for easy configuration tips.

Brief changelog

Generate spring-configuration-metadata.json for easy configuration tips.

Verifying this change

maven package Generated spring-configuration-metadata.json

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@walking98
Copy link
Contributor

Not quite understand the concreted usage for the customized ObjectMapper, can you please add some sample or demo? @ChunMengLu

@walking98
Copy link
Contributor

I understand the aim of the PR now. http://www.mdoninger.de/2015/05/16/completion-for-custom-properties-in-spring-boot.html

But still the auto prompt does not work in my IDEA when editing the application.properties, maybe relates to IDEA setting? need dig more ...

@aioair
Copy link

aioair commented May 8, 2019

I understand the aim of the PR now. http://www.mdoninger.de/2015/05/16/completion-for-custom-properties-in-spring-boot.html

But still the auto prompt does not work in my IDEA when editing the application.properties, maybe relates to IDEA setting? need dig more ...

IDEA is OK.
image

@walking98
Copy link
Contributor

My IDEA is Community Version, I think this is the reason.

https://stackoverflow.com/questions/31165390/intellij-spring-plugin-not-available

@walking98
Copy link
Contributor

This PR LGTM.

@ShannonDing ShannonDing added this to the 2.0.3 milestone May 8, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label May 8, 2019
@ShannonDing ShannonDing merged commit 72cd513 into apache:master May 8, 2019
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants