Merge d5cee4f into 03c1f11

apache · Nov 9, 2020 · 40e3718 · 40e3718
2 parents 03c1f11 + d5cee4f
commit 40e3718
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
@@ -27,15 +27,10 @@ public int getAndIncrement() {
         Integer index = this.threadLocalIndex.get();
         if (null == index) {
             index = Math.abs(random.nextInt());
-            if (index < 0)
-                index = 0;
             this.threadLocalIndex.set(index);
         }
 
         index = Math.abs(index + 1);
-        if (index < 0)
-            index = 0;
-
         this.threadLocalIndex.set(index);
         return index;
     }

diff --git a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
@@ -29,4 +29,11 @@ public void testGetAndIncrement() throws Exception {
         assertThat(localIndex.getAndIncrement()).isEqualTo(initialVal + 1);
     }
 
+    @Test
+    public void testGetAndIncrement2() throws Exception {
+        ThreadLocalIndex localIndex = new ThreadLocalIndex();
+        int initialVal = localIndex.getAndIncrement();
+        assertThat(initialVal >= 0);
+    }
+
 }