fix npe of SendMessageProcessorTest (#3632)

Co-authored-by: haozhijie <“haozhijie_9527@163.com”>
apache · Dec 13, 2021 · 7d1b001 · 7d1b001
1 parent e1571ee
commit 7d1b001
Showing 1 changed file with 24 additions and 4 deletions.
diff --git a/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java b/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java
@@ -195,25 +195,45 @@ public void incGroupGetNums(final String group, final String topic, final int in
     }
 
     public String buildStatsKey(String topic, String group) {
-        StringBuilder strBuilder = new StringBuilder(topic.length() + group.length() + 1);
+        StringBuilder strBuilder;
+        if (topic != null && group != null) {
+            strBuilder = new StringBuilder(topic.length() + group.length() + 1);
+        } else {
+            strBuilder = new StringBuilder();
+        }
         strBuilder.append(topic).append("@").append(group);
         return strBuilder.toString();
     }
 
     public String buildStatsKey(String topic, int queueId) {
-        StringBuilder strBuilder = new StringBuilder(topic.length() + 5);
+        StringBuilder strBuilder;
+        if (topic != null) {
+            strBuilder = new StringBuilder(topic.length() + 5);
+        } else {
+            strBuilder = new StringBuilder();
+        }
         strBuilder.append(topic).append("@").append(queueId);
         return strBuilder.toString();
     }
 
     public String buildStatsKey(String topic, int queueId, String group) {
-        StringBuilder strBuilder = new StringBuilder(topic.length() + group.length() + 6);
+        StringBuilder strBuilder;
+        if (topic != null && group != null) {
+            strBuilder = new StringBuilder(topic.length() + group.length() + 6);
+        } else {
+            strBuilder = new StringBuilder();
+        }
         strBuilder.append(topic).append("@").append(queueId).append("@").append(group);
         return strBuilder.toString();
     }
 
     public String buildStatsKey(int queueId, String topic, String group) {
-        StringBuilder strBuilder = new StringBuilder(topic.length() + group.length() + 6);
+        StringBuilder strBuilder;
+        if (topic != null && group != null) {
+            strBuilder = new StringBuilder(topic.length() + group.length() + 6);
+        } else {
+            strBuilder = new StringBuilder();
+        }
         strBuilder.append(queueId).append("@").append(topic).append("@").append(group);
         return strBuilder.toString();
     }