[ISSUE #6057] Modify magic number code

apache · Feb 23, 2023 · bf11311 · bf11311
1 parent 0ec8c92
commit bf11311
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/RegisterBrokerBody.java b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/RegisterBrokerBody.java
@@ -45,6 +45,7 @@ public class RegisterBrokerBody extends RemotingSerializable {
     private static final Logger LOGGER = LoggerFactory.getLogger(LoggerName.COMMON_LOGGER_NAME);
     private TopicConfigAndMappingSerializeWrapper topicConfigSerializeWrapper = new TopicConfigAndMappingSerializeWrapper();
     private List<String> filterServerList = new ArrayList<>();
+    private static final long MINIMUM_TAKE_TIME_MILLISECOND = 50;
 
     public byte[] encode(boolean compress) {
 
@@ -99,9 +100,9 @@ public byte[] encode(boolean compress) {
             }
 
             outputStream.finish();
-            long interval = System.currentTimeMillis() - start;
-            if (interval > 50) {
-                LOGGER.info("Compressing takes {}ms", interval);
+            long takeTime = System.currentTimeMillis() - start;
+            if (takeTime > MINIMUM_TAKE_TIME_MILLISECOND) {
+                LOGGER.info("Compressing takes {}ms", takeTime);
             }
             return byteArrayOutputStream.toByteArray();
         } catch (IOException e) {
@@ -163,9 +164,9 @@ public static RegisterBrokerBody decode(byte[] data, boolean compressed, MQVersi
             registerBrokerBody.getTopicConfigSerializeWrapper().setTopicQueueMappingInfoMap(topicQueueMappingInfoMap);
         }
 
-        long interval = System.currentTimeMillis() - start;
-        if (interval > 50) {
-            LOGGER.info("Decompressing takes {}ms", interval);
+        long takeTime = System.currentTimeMillis() - start;
+        if (takeTime > MINIMUM_TAKE_TIME_MILLISECOND) {
+            LOGGER.info("Decompressing takes {}ms", takeTime);
         }
         return registerBrokerBody;
     }
@@ -212,12 +213,13 @@ public void setFilterServerList(List<String> filterServerList) {
         this.filterServerList = filterServerList;
     }
 
-    public static ConcurrentMap<String, TopicConfig> cloneTopicConfigTable(
+    private ConcurrentMap<String, TopicConfig> cloneTopicConfigTable(
         ConcurrentMap<String, TopicConfig> topicConfigConcurrentMap) {
-        ConcurrentHashMap<String, TopicConfig> result = new ConcurrentHashMap<>();
-        if (topicConfigConcurrentMap != null) {
-            result.putAll(topicConfigConcurrentMap);
+        if (topicConfigConcurrentMap == null) {
+            return null;
         }
+        ConcurrentHashMap<String, TopicConfig> result = new ConcurrentHashMap<>(topicConfigConcurrentMap.size());
+        result.putAll(topicConfigConcurrentMap);
         return result;
     }
 }