Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The log problem in Broker2Client.java #1992

Closed
areyouok opened this issue May 14, 2020 · 1 comment · Fixed by #1983
Closed

The log problem in Broker2Client.java #1992

areyouok opened this issue May 14, 2020 · 1 comment · Fixed by #1983
Labels
module/broker type/enhancement
Milestone
4.7.1

Comments

@areyouok
Copy link
Contributor

areyouok commented May 14, 2020 •
edited

org.apache.rocketmq.broker.client.net. Broker2Client

The parameter number is not match with log pattern.

for example:

log.error("Check transaction failed because invoke producer exception. group={}, msgId={}", group, messageExt.getMsgId(), e.getMessage());

So the e.getMessage() is lost in log file.
@areyouok
Copy link
Contributor Author

fix in
#1983

@duhenglucky duhenglucky added this to the 4.7.1 milestone May 15, 2020
RongtongJin added a commit that referenced this issue May 15, 2020
@RongtongJin
Merge pull request #1983 from areyouok/fix_Broker2Client_log
7f10536 
[ISSUE #1992] fix Broker2Client logs
@RongtongJin RongtongJin linked a pull request May 25, 2020 that will close this issue
[ISSUE #1992] fix Broker2Client logs #1983
Merged
6 tasks
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@RongtongJin
Merge pull request apache#1983 from areyouok/fix_Broker2Client_log
144301a 
[ISSUE apache#1992] fix Broker2Client logs
pulllock pushed a commit to pulllock/rocketmq that referenced this issue Oct 19, 2023
@RongtongJin
Merge pull request apache#1983 from areyouok/fix_Broker2Client_log
8423060 
[ISSUE apache#1992] fix Broker2Client logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/broker type/enhancement
Projects
None yet
Milestone
4.7.1
Development

Successfully merging a pull request may close this issue.

[ISSUE #1992] fix Broker2Client logs areyouok/rocketmq
3 participants
@areyouok @duhenglucky @RongtongJin