-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG , when role change but not register again #3381
Labels
Milestone
Comments
Good catch, I think forceRegister should be forced to true in here. Could you submit a pull request to fix it? |
Maybe the version number should be increased when role change |
This was referenced Oct 12, 2021
6 tasks
RongtongJin
pushed a commit
that referenced
this issue
Nov 3, 2021
Merged |
zhongxiongzeng
pushed a commit
to zhongxiongzeng/rocketmq
that referenced
this issue
Jan 17, 2022
devfat
pushed a commit
to devfat/rocketmq
that referenced
this issue
Mar 3, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this issue
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I run rocket with
#版本号的方式注册
forceRegister=false
#预先设定好的leader
preferredLeaderId=n0
if i kill the leader, n0 will become again leader.
but n0's brokerId = 1,not 0.
Because role change will not register again
BrokerOuterAPI # 281 ,only compare topicConfigWrapper.getDataVersion.
switch (response.getCode()) {
case ResponseCode.SUCCESS: {
QueryDataVersionResponseHeader queryDataVersionResponseHeader =
(QueryDataVersionResponseHeader) response.decodeCommandCustomHeader(QueryDataVersionResponseHeader.class);
changed = queryDataVersionResponseHeader.getChanged();
byte[] body = response.getBody();
if (body != null) {
nameServerDataVersion = DataVersion.decode(body, DataVersion.class);
if (!topicConfigWrapper.getDataVersion().equals(nameServerDataVersion)) {
changed = true;
}
}
if (changed == null || changed) {
changedList.add(Boolean.TRUE);
}
}
default:
break;
}
The text was updated successfully, but these errors were encountered: