Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code style in namesrv module #4634

Closed
PansonPanson opened this issue Jul 19, 2022 · 1 comment
Closed

fix code style in namesrv module #4634

PansonPanson opened this issue Jul 19, 2022 · 1 comment
Labels
module/namesrv type/code style

Comments

@PansonPanson
Copy link
Contributor

I have read over the sourcecode of namesrv module，there are some code snippets need to be fixed.

image

  1. grammatical error
    image

  2. 中文语句不通顺，中、英文逗号混用
    image

  3. redundant parameter
    image

  4. apache commons
    image

  5. for each
    image

  6. redundant code
    image

  7. try with resources
    image

  8. replace with append
    image

image
PansonPanson added a commit to PansonPanson/rocketmq that referenced this issue Jul 19, 2022
@PansonPanson
[ISSUE apache#4634] fix code style in namesrv module
177de73
PansonPanson added a commit to PansonPanson/rocketmq that referenced this issue Jul 20, 2022
@PansonPanson
[ISSUE apache#4634] fix CI error
3ca6b13
@realJackSun
Copy link

LGFM

PansonPanson added a commit to PansonPanson/rocketmq that referenced this issue Sep 21, 2022
@PansonPanson
[ISSUE apache#4634] fix code style in namesrv module
3cf61fe
aaron-ai pushed a commit that referenced this issue Sep 22, 2022
@PansonPanson
[ISSUE #4634] fix code style in namesrv module (#5159)
aa33061
drpmma pushed a commit that referenced this issue Feb 21, 2023
@PansonPanson @drpmma
[ISSUE #4634] fix code style in namesrv module (#5159)
fcddf25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/namesrv type/code style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@duhenglucky @PansonPanson @aaron-ai @realJackSun