Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable checkstyle for test code #5122

Closed
aaron-ai opened this issue Sep 20, 2022 · 3 comments · Fixed by #5193
Closed

Enable checkstyle for test code #5122

aaron-ai opened this issue Sep 20, 2022 · 3 comments · Fixed by #5193
Assignees
@nowinkeyy
Labels
Good First Issue Good First Issue

Comments

@aaron-ai
Copy link
Member

To improve the quality of test code, checkstyle should be enabled.

  <executions>
      <execution>
          <id>verify</id>
          <phase>verify</phase>
          <configuration>
              <configLocation>style/rmq_checkstyle.xml</configLocation>
              <encoding>UTF-8</encoding>
              <consoleOutput>true</consoleOutput>
              <failsOnError>true</failsOnError>
              <!-- test checkstyle is disabled here -->
              <includeTestSourceDirectory>false</includeTestSourceDirectory>
          </configuration>
          <goals>
              <goal>check</goal>
          </goals>
      </execution>
  </executions>
@aaron-ai aaron-ai added the Good First Issue Good First Issue label Sep 20, 2022
@aaron-ai aaron-ai changed the title Enable checkstyle for test Enable checkstyle for test code Sep 20, 2022
@tsunghanjacktsai tsunghanjacktsai mentioned this issue Sep 20, 2022
Closed
@nowinkeyy
Copy link
Contributor

i will make it.

@aaron-ai
Copy link
Member Author

aaron-ai commented Sep 20, 2022 •
edited

i will make it.

Nice! I assigned it to you.

@nowinkeyy
Copy link
Contributor

Hi @aaron-ai. I submitted a PR for this isse. #5166

nowinkeyy added a commit to nowinkeyy/rocketmq that referenced this issue Sep 26, 2022
@nowinkeyy
[ISSUE apache#5122] Enable checkstyle for test code
51d386a
This was referenced Sep 26, 2022
Closed
Merged
lizhanhui added a commit that referenced this issue Sep 28, 2022
@nowinkeyy @aaron-ai @lizhanhui
[ISSUE #5122] Enable checkstyle for test code (rocketmq-broker module) (
d52be62 
#5193)

* style(pom):Enable checkstyle for test code

* style(broker):Enable checkstyle for test code

* Update pom.xml

* Enable checkstyle for tests of broker module

* Remove delete tmp file assertion as OS may have cron job to clean them

* Fix bazel issue

Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
This was referenced Sep 28, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
drpmma pushed a commit that referenced this issue Feb 21, 2023
@nowinkeyy @aaron-ai
@lizhanhui @drpmma
[ISSUE #5122] Enable checkstyle for test code (rocketmq-broker module) (
daf0337 
#5193)

* style(pom):Enable checkstyle for test code

* style(broker):Enable checkstyle for test code

* Update pom.xml

* Enable checkstyle for tests of broker module

* Remove delete tmp file assertion as OS may have cron job to clean them

* Fix bazel issue

Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nowinkeyy nowinkeyy

Labels
Good First Issue Good First Issue
Projects
None yet
Milestone
No milestone
2 participants
@aaron-ai @nowinkeyy