Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize AutoSwitchHAConnection HandShake's data protocol #5157

Closed
1 task done
mxsm opened this issue Sep 21, 2022 · 3 comments · Fixed by #5182
Closed
1 task done

Optimize AutoSwitchHAConnection HandShake's data protocol #5157

mxsm opened this issue Sep 21, 2022 · 3 comments · Fixed by #5182
Labels
module/ha high availably related

Comments

@mxsm
Copy link
Member

mxsm commented Sep 21, 2022 •
edited
Loading

when Broker master received Broker master handshake data, then Broker master will send back the handshake data to broker slave.
image
EpochStartOffset and Additional not need in handshake. So need to remove two fieds to reduce data transfer.and Keep it consistent with the documentation

  1. Please tell us about your environment:
    branch: develop
  • WIP
@mxsm mxsm changed the title Optimize AutoSwitchHAConnection send HandShake protocol Optimize AutoSwitchHAConnection HandShake's data protocol Sep 21, 2022
@HScarb HScarb added the module/ha high availably related label Sep 22, 2022
@misselvexu
Copy link

misselvexu commented Sep 22, 2022 •
edited
Loading

/assigned ?

@misselvexu
Copy link

/assigned

@mxsm
Copy link
Member Author

mxsm commented Sep 22, 2022

@misselvexu I will fix it

mxsm added a commit to mxsm/rocketmq that referenced this issue Sep 24, 2022
@mxsm
[ISSUE apache#5157]Optimize AutoSwitchHAConnection HandShake's data p…
97c6718 
…rotocol
@mxsm mxsm mentioned this issue Sep 24, 2022
Merged
6 tasks
mxsm added a commit to mxsm/rocketmq that referenced this issue Sep 24, 2022
@mxsm
[ISSUE apache#5157]Optimize AutoSwitchHAConnection HandShake's data p…
e4949cc 
…rotocol
mxsm added a commit to mxsm/rocketmq that referenced this issue Nov 17, 2022
@mxsm
[ISSUE apache#5157]Optimize AutoSwitchHAConnection HandShake's data p…
6a90b77 
…rotocol
RongtongJin pushed a commit that referenced this issue Nov 17, 2022
@mxsm
[ISSUE #5157] Optimize AutoSwitchHAConnection HandShake's data protoc…
0c3b405 
…ol (#5182)
drpmma pushed a commit that referenced this issue Feb 21, 2023
@mxsm @drpmma
[ISSUE #5157] Optimize AutoSwitchHAConnection HandShake's data protoc…
f3da467 
…ol (#5182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/ha high availably related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #5157]Optimize AutoSwitchHAConnection HandShake's data protocol mxsm/rocketmq
3 participants
@misselvexu @HScarb @mxsm