Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AutoSwitchRoleBase#nextPort method #6060

Closed
mxsm opened this issue Feb 14, 2023 · 2 comments · Fixed by #6068
Closed

Optimize AutoSwitchRoleBase#nextPort method #6060

mxsm opened this issue Feb 14, 2023 · 2 comments · Fixed by #6068

Comments

@mxsm
Copy link
Member

mxsm commented Feb 14, 2023

The issue tracker is used for bug reporting purposes ONLY whereas feature request needs to follow the RIP process. To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.

It is recommended to start a discussion thread in the mailing lists in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.

Generally, fixing an issue goes through the following steps:

  1. Understand the issue reported;
  2. Reproduce the unexpected behavior locally;
  3. Perform root cause analysis to identify the underlying problem;
  4. Create test cases to cover the identified problem;
  5. Work out a solution to rectify the behavior and make the newly created test cases pass;
  6. Make a pull request and go through peer review;

As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:

BUG REPORT

  1. Please describe the issue you observed:

image
Remove the recursive call when binding port error occurs.

  1. Please tell us about your environment:

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:

@francisoliverlee
Copy link
Member

可以补充下原方法的问题和优化思路,有单测的话更好

@mxsm
Copy link
Member Author

mxsm commented Feb 14, 2023

可以补充下原方法的问题和优化思路,有单测的话更好

@francisoliverlee 这个就是测试里面的一个基本类, 我补充一下以优化思路

mxsm added a commit to mxsm/rocketmq that referenced this issue Feb 14, 2023
RongtongJin pushed a commit that referenced this issue Mar 2, 2023
* [ISSUE #6060]Optimize AutoSwitchRoleBase#nextPort method

* polish code

* polish code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants