Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Extract the interval of fetchNameServerAddr #6910

Closed
1 task done
lizhimins opened this issue Jun 15, 2023 · 3 comments · Fixed by #6912
Closed
1 task done

[Enhancement] Extract the interval of fetchNameServerAddr #6910

lizhimins opened this issue Jun 15, 2023 · 3 comments · Fixed by #6912
Assignees
@totalo
Labels
Good First Issue Good First Issue type/enhancement

Comments

@lizhimins
Copy link
Member

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

The task of the Broker to discover the NameServer is performed by BrokerOuterAPI#fetchNameServerAddr at an interval of 2 minutes. The registration interval in BrokerController#registerBrokerAll is 10 seconds.

If the address of the NameServer changes, the Broker may not be able to discover the new NameServer and register with it in a timely manner. It is suggested to extract the interval of fetchNameServerAddr as a parameter for the Broker.

Motivation

The task of the Broker to discover the NameServer is performed by BrokerOuterAPI#fetchNameServerAddr at an interval of 2 minutes. The registration interval in BrokerController#registerBrokerAll is 10 seconds.

Describe the Solution You'd Like

It is suggested to extract the interval of fetchNameServerAddr as a parameter for the Broker.

Describe Alternatives You've Considered

None

Additional Context

No response
@totalo
Copy link
Member

totalo commented Jun 15, 2023

hi i want to do this. thx

@lizhimins
Copy link
Member Author

Suggest set default interval to 10 secones like registerBrokerAll()

@WindSearcher
Copy link

can i try it？

@totalo totalo mentioned this issue Jun 16, 2023
Merged
RongtongJin added a commit that referenced this issue Jun 23, 2023
@totalo @RongtongJin
[ISSUE #6910] Extract the interval of fetchNameServerAddr
5d6ee63 
Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@totalo totalo

Labels
Good First Issue Good First Issue type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6910] Extract the interval of fetchNameServerAddr totalo/rocketmq
3 participants
@lizhimins @totalo @WindSearcher