Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown #762

Closed
zymming opened this issue Feb 14, 2019 · 3 comments
Closed

defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown #762

zymming opened this issue Feb 14, 2019 · 3 comments

Comments

@zymming
Copy link

zymming commented Feb 14, 2019 •
edited

4.4.0版本

  1. defaultAsyncSenderExecutor在DefaultMQProducerImpl关闭时，没有调用shutdown。必须外部代码手动调用

  2. 不管asyncSenderExecutor有没有设置值， defaultAsyncSenderExecutor都会初始化，如果asyncSenderExecutor设置了值，defaultAsyncSenderExecutor再初始化，初始化了多余的线程池
@zongtanghu
Copy link
Contributor

Firstly,you should put forward a issue according to issue's template.@zymming

@zongtanghu
Copy link
Contributor

We will confirm this issue in these days. @zymming

ShannonDing pushed a commit that referenced this issue Feb 28, 2019
@zongtanghu @ShannonDing
[ISSUE #762]fix defaultAsyncSenderExecutor not shutdown when Default…
13eeab8 
…MQProducerImpl shutdown. (#880)

[ISSUE #762 ]fix defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown.
@zongtanghu zongtanghu mentioned this issue Feb 28, 2019
Merged
6 tasks
yuer1727 added a commit to yuer1727/rocketmq that referenced this issue Apr 20, 2019
@yuer1727
合并源最新代码 (#1)
1a0f55d 
* correct some edit-errors.

* some edit errors is corrected.

* some edit errors is corrected.

* [RIP-9]add the msg trace and acl feature content of RocketMQ doc part. (apache#707)

* [RIP-9]add the msg trace of RocketMQ doc part

* [RIP-9]add the acl feature of RocketMQ doc part

* [RIP-9]adjust the title number of the acl feature doc part for RocketMQ

* [RIP-9]adjust the formate of RocketMQ acl doc part.

* 1. Modified the format

* Add the best practice of RocketMQ

* Modify the format of the title

* Update best_practice.md

* Add ACL and Message trace feature in README file.

* [ISSUE apache#731] Change log level in TransactionalMessageServiceImpl

* Do not send heartbeat for every pull request

* RIP-9 RocketMQ Develop Guide: add description section for broker configuration

* Revise section format and reword some sentences for broker configuration section

* Revise some title format

* [RIP-9]Add the features of RocketMQ into the develop guide for users (apache#765)

[RIP-9]Add the features of RocketMQ into the develop guide for users

* [RIP-9]add the design content of RocketMQ doc part. (apache#732)

[RIP-9]add the design content of RocketMQ doc part.

* [RIP-9] Add the introduction of the basic samples in RocketMQ (apache#758)

 [RIP-9] Add the introduction of the basic samples in RocketMQ

* [RIP-9] Added sample English documents of English transaction messages

* add en doc of Operation FAQ

* [issue#790]fix defaultTopicPerm and defaultGroupPerm values which are in yaml config file dosen't work. (apache#798)

* [issue#790]fix defaultTopicPerm and defaultGroupPerm values which are in the yaml config file doesn't work.

* [issue#790]fix defaultTopicPerm and defaultGroupPerm doesn't work,fix the unit test.

* [RIP-9] Add a delay example in RocketMQ

[RIP-9] Add a delay example in RocketMQ

* [RIP-9] Add the introduction of the batch message samples in RocketMQ (apache#792)

[RIP-9] Add the introduction of the batch message samples in RocketMQ

* [RIP-9]Add the English docs for Filter Example of RocketMQ into the develop guide for users (apache#800)

[RIP-9]Add the English docs for Filter Example of RocketMQ into the develop guide for users

* [RIP-9] Add the English description document for Deployment.md (apache#780)

[RIP-9] Add the English description document for Deployment.md

* [RIP-10] Add test cases for DefaultMessageStore.putMessages (apache#777)

[RIP-10]Add test cases for DefaultMessageStore.putMessages(MessageExtBatch)

* [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue (apache#778)

[RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue

* [RIP-10] Add  test cases of  ScheduleMessageService (apache#782)

[RIP-10] Add  test cases of  ScheduleMessageService

* [RIP-10] Optimize test batch send message use cases(apache#831)

[RIP-10] Optimize test batch send message use cases

* Change the first character to upper case.

* [issue#789]fix NullPointerException in the PlainAccessValidator#parse() method when recieved some admin request command,if configed no aclRPCHook. (apache#819)

* [issue#790]fix defaultTopicPerm and defaultGroupPerm values which are in the yaml config file doesn't work.

* [issue#790]fix defaultTopicPerm and defaultGroupPerm doesn't work,fix the unit test.

* [issue#789]fix NullPointerException in the PlainAccessValidator#parse() method when recieved some admin request command,if configed no aclRPCHook.

* [RIP-9] Add the introduction of the access control list in RocketMQ (apache#791)

* Add the introduction of the access control list in RocketMQ
* Format the list style

* [RIP-9]To add English version of Examples of Ordered Messages in docs/en/ (apache#795)

* To add the English version of Examples of Ordered Messages in docs/en/

* Format the style using MD gramma.

* [RIP-9] Commit docs Example_OpenMessaging.md (apache#797)

[RIP-9] Commit docs Example_OpenMessaging.md

* Polish pom to use dledger 0.1 from central repo

* [RIP-9]Add English docs of transactional message design (apache#804)

* add english document of transaction message design

* Format the style.

* [RIP-9] Add english document of storage design(apache#809)

[RIP-9] Add english document of storage design

* [RIP-10]  Add test cases for CheckClientRequestBody (apache#808)

* [RIP-10] Add test case for ConsumeStatsList (apache#814)

* [ISSUE apache#776] make mqadmin usage information more friendly to user(apache#796)

* [RIP-10] Add ClusterInfo testing case (apache#830)

* [RIP-10] Add test cases for TopicStatsTable.java (apache#832)

* [RIP-10] Fix junit bug in ScheduleMessageServiceTest (apache#839)

[RIP-10] Fix junit bug in ScheduleMessageServiceTest

* [RIP-10]Add  test case for CommitLog.handleHA (apache#829)

* Add test case for CommitLog.handleHA

* Add one UUID parent path for RocketMQ's files

* [RIP-10] Add test case for KVTable (apache#828)

[RIP-10] Add test case for KVTable

* [RIP-10]  Add test cases for DefaultMessageStore.CleanCommitLogService and DefaultMessageStore.CleanConsumeQueueService (apache#836)

[RIP-10]  Add test cases for DefaultMessageStore.CleanCommitLogService and DefaultMessageStore.CleanConsumeQueueService

* [RIP-9] Add the introduction of the Operations_Producer in RocketMQ (apache#794)

[RIP-9] Add the introduction of the Operations_Producer in RocketMQ

*  [RIP-9] Add Operations_Trace.md in rocketmq (apache#859)

* [RIP-9] Add Operations_Trace.md in recketmq

* [RIP-9] Add the introduction of the basic concepts in RocketMQ (apache#793)

[RIP-9] Add the introduction of the basic concepts in RocketMQ

* [RIP-9]Add the client configuration section of the RocketMQ documentation best practices. (apache#799)

[RIP-9]Add the client configuration section of the RocketMQ documentation best practices.

* [RIP-9]Add English docs of architecture (apache#812)

[RIP-9]Add English docs of architecture

* [RIP-9] Add the Configuration_System in RocketMQ  (apache#885)

[RIP-9] Add the Configuration_System in RocketMQ

* [RIP-9] Add ta CLITools.md file to illustrate the use of  mqadmin management tools (apache#821)

[RIP-9] Add ta CLITools.md file to illustrate the use of  mqadmin management tools

* [RIP-9] Add API_Reference_DefaultMQProducer.md for Java (apache#837)

[RIP-9] Add API_Reference_DefaultMQProducer.md for Java

* [RIP-9] Commit docs Design_Filter.md (apache#840)

[RIP-9] Commit docs Design_Filter.md

* [RIP-9] Change the Chinese punctuation in Example_Delay.md to English punctuation (apache#878)

[RIP-9] Change the Chinese punctuation in Example_Delay.md to English punctuation

* [RIP-9] update the en doc for Troubleshoopting.md apache#881 (apache#883)

[RIP-9] update the en doc for Troubleshoopting.md apache#881

* [RIP-9] Add the FAQ in RocketMQ (apache#879)

[RIP-9] Add the FAQ in RocketMQ

* [RIP-9] Delete the number on the title (apache#887)

[RIP-9] Delete the number on the title

* [RIP-9] Update incorrect symbol  (apache#886)

[RIP-9] update incorrect symbol

* [RIP-9] enhance description about the state "SLAVE_NOT_AVAILABLE" in the chinese version of "best_practice.md" (apache#867)

* [RIP-9]Polish Best practice.md (apache#890)

* [RIP-9] Modify the wrong architecture diagram. (apache#891)

* [RIP-9]Change the project number to a solid black dot (apache#893)

* Update '同步消息，' to '同步消息、' and delete the ordinal number of subsection 3.4

* [RIP-10]fix-bug: ScheduleMessageServiceTest (apache#869)

[RIP-10]fix-bug: ScheduleMessageServiceTest

* [RIP-9] Modify English document for Example_Orderly.md (apache#902)

[RIP-9] Modify English document for Example_Orderly.md

* [RIP-10] Add test cases for ConsumerConnection (apache#834)

* use putIfAbsent instead of put

* 1.use putIfAbsent instead of put method of ConcurrentHashMap 2.add test code

* rewrite unit test BrokerStatsManagerTest.java

* use putIfAbsent in MomentStatsItemSet.java

* adjust test code to increase coverage

* [RIP-10]  Add test cases for   ConsumeMessageConcurrentlyService consume success status (apache#888)

 [RIP-10]  Add test cases for   ConsumeMessageConcurrentlyService consume success status

* [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody (apache#898)

[RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody

* [RIP-10] Add test cases for SubscriptionGroupWrapper (apache#899)

[RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody

* [RIP-10] Fix-ScheduleMessageServiceTest (apache#928)

[RIP-10] Fix-ScheduleMessageServiceTest

* [RIP-10] Add test cases for UpdateKvConfigCommand (apache#929)

[RIP-10] Add test cases for UpdateKvConfigCommand

* [RIP-9] Add the English docs for Feature.md into the develop guide for users (apache#825)

[RIP-9] Add the English docs for Feature into the develop guide for users

* [RIP-9] Modify Chinese punctuation to English (apache#896)

[RIP-9] Modify Chinese punctuation to English

* [RIP-9] Add the introduction of the Operations_Consumer in RocketMQ(apache#897)

[RIP-9] Add the introduction of the Operations_Consumer in RocketMQ

* [RIP-9] Add English document to Design_Query(apache#901)

[RIP-9] Add English document to Design_Query

* [RIP-9] Add English document for Design_Trancation.md (apache#908)

[RIP-9] Add English document for Design_Trancation.md

*  [ISSUE apache#762]fix defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown. (apache#880)

[ISSUE apache#762 ]fix defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown.

* [RIP-9] Add English document for Design_LoadBlancing.md and Design_Remoting.md (apache#810)

[RIP-9] Add English document for Design_LoadBlancing.md and Design_Remoting.md

* [RIP-9] Modify Chinese punctuation to English (apache#941)

[RIP-9] Modify Chinese punctuation to English

* delete useless image references and correct the description

* [RIP-9]

Add the introduction of the terminology in RocketMQ

* [RIP-9]

Add the introduction of the terminology in RocketMQ

* [RIP-9]

Add the introduction of the terminology in RocketMQ

* [RIP-9] Modify the numbering style of the first paragraph

* Modify incorrect word

* [RIP-10]HA test case optimization and reduce the time spent (apache#931)

[RIP-10]HA test case optimization and reduce the time spent

* [RIP-10]Optimize the test case for DefaultMessageStore.CleanCommitLogService and DefaultMessageStore.CleanConsumeQueueService (apache#939)

[RIP-10]Optimize the test case for DefaultMessageStore.CleanCommitLogService and DefaultMessageStore.CleanConsumeQueueService

* [RIP-9] Modify English document for Design_Trancation.md

* 更新因为文档:Future.md

* [RIP-9] Modify English document for Design_Store.md

"TransactionalMessageUtil" need not be changed to "TransactionMessageUtil ",modify the last submitted mistake.

* Update Design_Trancation.md

* Update Example_Filter.md

* [RIP-9] Polish Example_Orderly.md

* Update Design_Store.md

编号75:更新英文文档：Design_Store.md

* Modify English document for Example_Transaction.md

* Update Operations_Producer.md

Add a period at the end of the first paragraph

* Update Design_Filter.md

* [RIP-76] Remove unnecessary dots for Design_Trancation.md

* Modify English document

* update Design_loadBlancing.md

* remove "." behind the number in each title

* [RIP-9] update the title and delete cluster setup

* Update Feature.md in RocketMQ/docs/en

* [RIP-9] update Concept.md in RocketMQ docs/en

* [RIP-9] update Concept.md and change '.' to ',' in RocketMQ docs/en

* update rocketmq/docs/en/Example_Delay.md, delete some punctuation character

* Delete the Introduction and underline

* [RIP-78] update Example_Filter.md in RocketMQ docs/en

* [RIP-9]Delete the Introduction and underlines

* Update Example_Orderly.md

* Update Design_Remoting.md

* Update Design_Remoting.md

* [RIP-78] update Design_LoadBlancing.md in RocketMQ docs/en

* [RIP-9]Delete the Introduction and underlines

* [RIP-70] update Deployment.md in RocketMQ docs/en

* [RIP-9] Polish Operations_Trace.md

* Modify Deployment.md in RocketMQ docs/en

* [RIP-78] update Example_Filter.md in RocketMQ docs/en

* [RIP-9] Update Configuration_System.md in RocketMQ docs/en:some problems in grammer

* Update Configuration_System.md

* format

* Update Operations_Producer.md

* Update Configuration_System.md

 JVM Options :A simple JVM configurations looks like this	改为A simple JVM configuration is as follows

* [RIP-65] Delete chinese period in CLITools.md file

* Change Configuration_System : We recommend set 655350 - We recommend setting 655350

* [RIP-9] update Concept.md in RocketMQ docs/en

* Example_Delay.md

[RIP-77]Modify the last paragraph and rid of punctuation between each section number and title

* New Change Configuration_System : We recommend set 655350 - We recommend setting 655350

* Number the titles of Configuration_Client.md

* update Configuration_System.md

* [RIP-9] Update Deployment.md in RocketMQ

* [RIP-9] Changed'.For clusters of multiple NameServer'  . For clusters of multiple NameServer

* [RIP-9] update Deployment.md in docs/en

* Update Configuration_System.md

* Update copyright year

* Update NOTICE

* [RIP-9] Add doc of best practice for broker (apache#774)

[RIP-9] Add doc of best practice for broker

* [RIP-9]Modify English document for Example_Orderly.md (apache#944)

* [RIP-9] Add the system configuration option doc: Direct ByteBuffer memory size

[RIP-9] Add the system configuration option doc: Direct ByteBuffer memory size

* fix Design_Remoting.md issues no 103-105

* modify (2)

* Add copywright for some files

* [RIP-9] Modify the article layout format (apache#1033)

* Modify the article layout format

* Update Design_Store.md

* [RIP-10] modify test case  StatsItemSetTest's param (apache#1053)

* [RIP-10] optimization test case of DefaultMessageStore (apache#995)

* [RIP-9]Modify Design_Remoting.md

* [RIP-9] Update Configuration_System.md

* [RIP-10]ConsumeMessageConcurrentlyServiceTest maybe effect other case,Ignore part test function

* Update Configuration_System.md

* Update Configuration_System.md

* Modify English document for Configuration_System.md

* [RIP-9]Delete the Introduction and underlines

* [RIP-9] update FAQ.md in RocketMQ docs/en

* [RIP-9]remove "**" from headline and adjust some content formate

* [RIP-10] Add test cases for ConsumerRunningInfo (apache#923)

* [RIP-9](Operation) within deleted title(apache#1066)

* [PIR-10] add test for GroupList (apache#807)

* [RIP-9] Modify the numbering style

* Update Design_Store.md

* [RIP-9] Modify English document for Design_Trancation.md

* [ISSUE apache#1086] Fix NullPointerException in PlainPermissionLoader if permissions are not configured(with admin user)

* update verion 4.5.0

* update the format of RocketMQ User Guide

* Format the title of user guide readme file

* Update concept.md

modify the format of concept.md

* Update features.md

Modified the format of features.md

* Update architecture.md

Modified the format of architecture.md

* Update RocketMQ_Example.md

Modified the format of  RocketMQ_Example.md

* Update quick_start.md

Modified the format of quick_start.md

* Update deploy_guide.md

Modified the format of deploy_guide.md

* Update README.md

Modified the format of README.md

* [maven-release-plugin] prepare release rocketmq-all-4.5.0

* delete blank chart line
@ShannonDing
Copy link
Member

close due to PR merged.

JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this issue May 28, 2020
@zongtanghu @ShannonDing
[ISSUE apache#762]fix defaultAsyncSenderExecutor not shutdown when D…
22b0171 
…efaultMQProducerImpl shutdown. (apache#880)

[ISSUE apache#762 ]fix defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown.
pulllock pushed a commit to pulllock/rocketmq that referenced this issue Oct 19, 2023
@zongtanghu @ShannonDing
[ISSUE apache#762]fix defaultAsyncSenderExecutor not shutdown when D…
54ddb2e 
…efaultMQProducerImpl shutdown. (apache#880)

[ISSUE apache#762 ]fix defaultAsyncSenderExecutor not shutdown when DefaultMQProducerImpl shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zongtanghu @zymming @ShannonDing