[ROCKETMQ-219] Add batch example #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongeforever
force-pushed
the
ROCKETMQ-219
branch
from
66f05cf
to
d1db5af
Compare
Jaskey
reviewed
Jun 7, 2017
| import org.apache.rocketmq.client.producer.DefaultMQProducer; | ||
| import org.apache.rocketmq.common.message.Message; | ||
|
|
||
| public class SplitBatchProducer { |
There was a problem hiding this comment.
What about adding comments to this sample class to explain what it is going to demonstrate, since this example seem to be a little complicated.
There was a problem hiding this comment.
Good to add a concise explanation why we should split when sending in batch. That is, total message size of messages in a batch cannot exceed 1 mega bytes on default.
|
Overall +1 |
|
+1, LGTM~ |
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2017
|
@zhouxinyu Thanks |
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2017
|
rocketmq version 4.5 , SimpleBatchProducer 会出现： |
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ROCKETMQ-219
@lizhanhui @zhouxinyu