[ROCKETMQ-278] Add clusterlist cmd by specified cluster #152

lindzh · 2017-08-24T08:40:21Z

What is the purpose of the change

When using mqadmin command clusterlist, it always display all cluster, I want to display specified cluster. JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-278.

Brief change log

add mqadmin clusterlist selected by cluster.

Verifying this change

This change is a trivial rework / code cleanup with unit test coverage.
execute mqadmin clusterlist -c {slecified cluster} to verify.

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand the pull request :
- What is the purpose of the change
- Brief change log
- Verifying this change
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

…evelop

coveralls · 2017-08-24T09:08:08Z

Coverage increased (+0.02%) to 39.046% when pulling 2df4cfc on lindzh:add_clusterlist_cluster into ca14a2d on apache:develop.

coveralls · 2017-08-24T09:08:08Z

Coverage increased (+0.02%) to 39.046% when pulling 2df4cfc on lindzh:add_clusterlist_cluster into ca14a2d on apache:develop.

…evelop

coveralls · 2017-08-28T11:15:45Z

Coverage increased (+0.03%) to 38.68% when pulling a674878 on lindzh:add_clusterlist_cluster into 4c5e58b on apache:develop.

vsair · 2017-08-29T01:50:35Z

nice!

shroman · 2017-09-15T07:14:41Z

namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java

-        clusterInfoSerializeWrapper.setBrokerAddrTable(this.brokerAddrTable);
-        clusterInfoSerializeWrapper.setClusterAddrTable(this.clusterAddrTable);
-        return clusterInfoSerializeWrapper.encode();
+    public byte[] getAllClusterInfo(String cluster) {


You change the signature of the public method here.
How about having another method -- public byte[] getAllClusterInfo()? And you won't need calling getAllClusterInfo(null) then too ;)

I agree @shroman here

dongeforever · 2017-09-20T04:01:01Z

LGTM @zhouxinyu @vongosling

vongosling · 2017-09-20T04:08:36Z

client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java

@@ -1167,10 +1168,13 @@ public Properties getBrokerConfig(final String addr, final long timeoutMillis)
        throw new MQBrokerException(response.getCode(), response.getRemark());
    }

-    public ClusterInfo getBrokerClusterInfo(
+    public ClusterInfo getBrokerClusterInfo(String cluster,


how to insure the api compatibility

vongosling · 2017-09-20T04:09:25Z

namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java

-        clusterInfoSerializeWrapper.setBrokerAddrTable(this.brokerAddrTable);
-        clusterInfoSerializeWrapper.setClusterAddrTable(this.clusterAddrTable);
-        return clusterInfoSerializeWrapper.encode();
+    public byte[] getAllClusterInfo(String cluster) {


I agree @shroman here

vongosling · 2017-09-20T04:10:08Z

tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicListSubCommand.java

@@ -65,7 +65,7 @@ public void execute(final CommandLine commandLine, final Options options,
        try {
            defaultMQAdminExt.start();
            if (commandLine.hasOption('c')) {
-                ClusterInfo clusterInfo = defaultMQAdminExt.examineBrokerClusterInfo();
+                ClusterInfo clusterInfo = defaultMQAdminExt.examineBrokerClusterInfo(null);


null as parameter is not a good practice

Thanks,I will change it in the next commit.

coveralls · 2017-12-13T10:32:46Z

Coverage increased (+0.06%) to 42.377% when pulling 0ddcf00 on lindzh:add_clusterlist_cluster into b054a9d on apache:develop.

vongosling · 2018-07-14T02:34:07Z

@lindzh would you please resolve the conflicts, I will merge it.

lindzh · 2018-07-16T03:00:03Z

@vongosling conflicts has been resolved.

vongosling · 2018-07-16T08:53:05Z

Too much merge request commits, could you mind using git pull --rebase to polish your pr ?

vongosling · 2018-07-17T08:12:40Z

@lindzh Thanks, I will pick up the real codes to merge into the develop branch. Expect you to keep your eyes on the RocketMQ community :-)

lindzh added 6 commits August 11, 2017 15:55

Merge branch 'develop' of github.com:apache/incubator-rocketmq into d…

1ae0693

…evelop

Merge branch 'develop' of github.com:apache/incubator-rocketmq into d…

f0e243c

…evelop

Merge branch 'develop' of github.com:apache/incubator-rocketmq into d…

1810be4

…evelop

Merge branch 'develop' of github.com:apache/incubator-rocketmq into d…

53dcd8d

…evelop

add cluster list to specified cluster

aacb19c

add cluster info test

2df4cfc

lindzh changed the base branch from master to develop August 24, 2017 08:40

lindzh added 2 commits August 28, 2017 18:41

Merge branch 'develop' of github.com:apache/incubator-rocketmq into d…

4abfa4f

…evelop

Merge branch 'develop' into add_clusterlist_cluster

a674878

lindzh changed the title ~~[ROCKETMQ-278]add clusterlist cmd by specified cluster~~ [ROCKETMQ-278]Add clusterlist cmd by specified cluster Sep 7, 2017

lindzh changed the title ~~[ROCKETMQ-278]Add clusterlist cmd by specified cluster~~ [ROCKETMQ-278] Add clusterlist cmd by specified cluster Sep 7, 2017

This was referenced Sep 7, 2017

[ROCKETMQ-193] Develop rocketmq-redis-replicator component apache/rocketmq-externals#29

Merged

[ROCKETMQ-286] Add a switch to decide whether to wake up commitLogService when put message #162

Closed

shroman reviewed Sep 15, 2017

View reviewed changes

vongosling reviewed Sep 20, 2017

View reviewed changes

fix old api

590ffb2

Merge branch 'develop' into fix_cluster_list

0ddcf00

vongosling closed this Jul 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ROCKETMQ-278] Add clusterlist cmd by specified cluster #152

[ROCKETMQ-278] Add clusterlist cmd by specified cluster #152

lindzh commented Aug 24, 2017 •

edited

coveralls commented Aug 24, 2017

coveralls commented Aug 24, 2017

coveralls commented Aug 28, 2017

vsair commented Aug 29, 2017

shroman Sep 15, 2017 •

edited

vongosling Sep 20, 2017

dongeforever commented Sep 20, 2017

vongosling Sep 20, 2017

vongosling Sep 20, 2017

vongosling Sep 20, 2017

lindzh Dec 13, 2017

coveralls commented Dec 13, 2017 •

edited

vongosling commented Jul 14, 2018

lindzh commented Jul 16, 2018

vongosling commented Jul 16, 2018

vongosling commented Jul 17, 2018

[ROCKETMQ-278] Add clusterlist cmd by specified cluster #152

[ROCKETMQ-278] Add clusterlist cmd by specified cluster #152

Conversation

lindzh commented Aug 24, 2017 • edited

What is the purpose of the change

Brief change log

Verifying this change

coveralls commented Aug 24, 2017

coveralls commented Aug 24, 2017

coveralls commented Aug 28, 2017

vsair commented Aug 29, 2017

shroman Sep 15, 2017 • edited

Choose a reason for hiding this comment

vongosling Sep 20, 2017

Choose a reason for hiding this comment

dongeforever commented Sep 20, 2017

vongosling Sep 20, 2017

Choose a reason for hiding this comment

vongosling Sep 20, 2017

Choose a reason for hiding this comment

vongosling Sep 20, 2017

Choose a reason for hiding this comment

lindzh Dec 13, 2017

Choose a reason for hiding this comment

coveralls commented Dec 13, 2017 • edited

vongosling commented Jul 14, 2018

lindzh commented Jul 16, 2018

vongosling commented Jul 16, 2018

vongosling commented Jul 17, 2018

lindzh commented Aug 24, 2017 •

edited

shroman Sep 15, 2017 •

edited

coveralls commented Dec 13, 2017 •

edited