[RIP-18]Add opentracing support for Apache RocketMQ #1525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vongosling
reviewed
Oct 12, 2019
vongosling
reviewed
Oct 14, 2019
|
|
||
| @Override | ||
| public void sendMessageBefore(SendMessageContext context) { | ||
| span = tracer.buildSpan("sendMessage").asChildOf(rootSpan).start(); |
There was a problem hiding this comment.
Could we extract concrete buildspan parameter to a provider extension while not this constant inject?
Comment on lines
+43
to
48
| <dependency> | ||
| <groupId>io.jaegertracing</groupId> | ||
| <artifactId>jaeger-client</artifactId> | ||
| <version>0.32.0</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
It would be better to write some unit test before writing use case examples. In addition, would you like to analyze your imported dependency and its children dependencies license are compatible with ASL 2.0？
There was a problem hiding this comment.
ok,I will add some unit tests ,and the dependency of jaeger-client is compatible with ASL 2.0.
|
Already done in #2860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add the support of opentracing
Brief changelog
Add the trace hook to sendMessage and consumeMessage
Add the Constructor to DefaultMQProducer and DefaultMQPushConsumer
Add examples of tracing producer and consumer by jaeger
Verifying this change
https://shimo.im/docs/gDhdTrrHjjQwycXv/
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.