Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCKETMQ-375] Fix typo in MQClientInstance’s log message #231

Closed
wants to merge 5 commits into from

Conversation

mark800
Copy link
Contributor

@mark800 mark800 commented Mar 1, 2018

What is the purpose of the change

Fix typo in MQClientInstance’s log message

Brief changelog

ClinetID -> ClientID

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 39.955% when pulling 93f515b on mark800:ROCKETMQ-375 into 2d43e75 on apache:master.

@vongosling
Copy link
Member

Well done. Next, 2 hints for works. Please transfer your PR to RocketMQ develop branch while not master. Another, Could you tell us why do you use our template for pr?

@mark800 mark800 changed the base branch from master to develop March 8, 2018 06:43
@mark800
Copy link
Contributor Author

mark800 commented Mar 8, 2018

@vongosling do you mean "why not use template for pr"? well I think this tiny change doesn't need that long list :)

@vongosling
Copy link
Member

@mark800 Thanks, I will fix the typo.

@vongosling vongosling closed this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants