Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-19] Pop Consuming (submodule "common") #2721

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

ayanamist
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

This is "common" submodule of contribution for RIP-19

Brief changelog

Add some necessary codes to support RIP-19

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 51.463% when pulling 86bea21 on ayanamist:pop_consumer into e277216 on apache:pop_consumer.

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #2721 (86bea21) into pop_consumer (e277216) will decrease coverage by 0.44%.
The diff coverage is 8.18%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             pop_consumer    #2721      +/-   ##
==================================================
- Coverage           46.31%   45.87%   -0.45%     
- Complexity           4353     4357       +4     
==================================================
  Files                 547      563      +16     
  Lines               36245    36648     +403     
  Branches             4809     4847      +38     
==================================================
+ Hits                16788    16812      +24     
- Misses              17375    17751     +376     
- Partials             2082     2085       +3     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/rocketmq/common/KeyBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/org/apache/rocketmq/common/PopAckConstants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ache/rocketmq/common/constant/ConsumeInitMode.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rg/apache/rocketmq/common/constant/LoggerName.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...apache/rocketmq/common/message/MessageDecoder.java 78.04% <ø> (ø) 24.00 <0.00> (ø)
...ocketmq/common/message/MessageQueueAssignment.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...g/apache/rocketmq/common/protocol/RequestCode.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../apache/rocketmq/common/protocol/ResponseCode.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...etmq/common/protocol/body/PopProcessQueueInfo.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mmon/protocol/body/QueryAssignmentRequestBody.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e277216...86bea21. Read the comment docs.

@duhenglucky duhenglucky added this to the 4.9.0 milestone Mar 10, 2021
@duhenglucky duhenglucky merged commit 60ad9ab into apache:pop_consumer Mar 17, 2021
@zongtanghu zongtanghu modified the milestones: 4.9.0, 4.9.1 Jun 16, 2021
@zongtanghu zongtanghu removed this from the 4.9.1 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants