Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2969] Add a skip accumulation message command in mqadmin. #2970

Conversation

zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#2969

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 53.967% when pulling 13f561b on zhangjidi2016:add_skipAccumulatedMessage_command into 5e99cdb on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #2970 (13f561b) into develop (5e99cdb) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2970      +/-   ##
=============================================
- Coverage      47.98%   47.81%   -0.18%     
+ Complexity      4567     4551      -16     
=============================================
  Files            552      552              
  Lines          36628    36628              
  Branches        4844     4844              
=============================================
- Hits           17577    17514      -63     
- Misses         16831    16883      +52     
- Partials        2220     2231      +11     
Impacted Files Coverage Δ
...apache/rocketmq/client/trace/TraceDataEncoder.java 54.30% <0.00%> (-15.24%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-8.96%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (-4.45%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...ache/rocketmq/store/AllocateMappedFileService.java 39.02% <0.00%> (-2.44%) ⬇️
...org/apache/rocketmq/client/trace/TraceContext.java 72.91% <0.00%> (-2.09%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e99cdb...13f561b. Read the comment docs.

@zongtanghu
Copy link
Contributor

LGTM

Copy link
Member

@francisoliverlee francisoliverlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisoliverlee francisoliverlee merged commit e154529 into apache:develop Jan 6, 2022
@XiaoyiPeng
Copy link
Contributor

XiaoyiPeng commented Jan 21, 2022

Can we close the issue #2969 ?

@zhangjidi2016 zhangjidi2016 deleted the add_skipAccumulatedMessage_command branch April 14, 2022 13:30
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…Message_command

[ISSUE apache#2969] Add a skip accumulation message command in mqadmin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants