[ISSUE #3102] win10 run unit tests. MessageStoreTestBase.class line86 file.delete()==false #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odbozhou
reviewed
Jul 14, 2021
| Assert.assertEquals(0, messageStore.dispatchBehindBytes()); | ||
| doGetMessages(messageStore, topic, 0, 1700, 0); | ||
| messageStore.shutdown(); | ||
| try { |
There was a problem hiding this comment.
It is not a good way to add exception capture in the test case, it is best to find the cause of the error and fix it.
There was a problem hiding this comment.
thanks for your suggestions, I will fix it
There was a problem hiding this comment.
In linux file.delete() can delete file even if the file is in mmap, but in windows it can't. I'm not familiar with this. Do you have any suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
Fixes #3102
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.