Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-21] RocketMQ Logic Queue #3153

Merged
merged 6 commits into from
Jul 20, 2021
Merged

[RIP-21] RocketMQ Logic Queue #3153

merged 6 commits into from
Jul 20, 2021

Conversation

chenzlalvin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

This PR implements the logical queue of RocketMQ, which enables elastic scaling of RocketMQ. When a node changes, the upper-layer queue does not change, and the solution does not need to replicate existing data.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky changed the title [RIP-21] RocketMQ Logicqueue [RIP-21] RocketMQ Logic Queue Jul 15, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 53.019% when pulling 297582b on chenzlalvin:logicqueue into aed47c3 on apache:5.0.0-preview.

@duhenglucky duhenglucky added type/rip progress/wip Work in progress. Accept or refused to be continue. labels Jul 16, 2021
@duhenglucky duhenglucky added this to the 5.0.0-preview milestone Jul 16, 2021
@@ -16,13 +16,18 @@
*/
package org.apache.rocketmq.broker;

import com.google.common.collect.Maps;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not import a new package.

@duhenglucky duhenglucky merged commit da5d30b into apache:5.0.0-preview Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress/wip Work in progress. Accept or refused to be continue. type/rip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants