Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue3205]Fix the issue of check style in client and broker modules. #3206

Merged
merged 1 commit into from Aug 1, 2021

Conversation

zongtanghu
Copy link
Contributor

@zongtanghu zongtanghu commented Aug 1, 2021

Make sure set the target branch to develop

What is the purpose of the change

Fix the issue of check style in client and broker modules.

Brief changelog

Fix the issue of check style in client and broker modules.

Verifying this change

I have already run the maven build command in my local enviroments.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zongtanghu zongtanghu added this to the 4.9.1 milestone Aug 1, 2021
@zongtanghu zongtanghu changed the title [#Issue3205]Fix the issue of code style in client and broker modules. [Issue3205]Fix the issue of code style in client and broker modules. Aug 1, 2021
@zongtanghu zongtanghu changed the title [Issue3205]Fix the issue of code style in client and broker modules. [Issue3205]Fix the issue of check style in client and broker modules. Aug 1, 2021
@duhenglucky duhenglucky merged commit ec985ee into apache:develop Aug 1, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 54.069% when pulling 73db297 on zongtanghu:develop_fix_4.9.1_codestyle into 5e58893 on apache:develop.

GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…style

[Issue3205]Fix the issue of check style in client and broker modules.
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
…style

[Issue3205]Fix the issue of check style in client and broker modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants