New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3286] replace Timer with ScheduledExecutorService #3287
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3287 +/- ##
=============================================
- Coverage 48.32% 48.25% -0.07%
+ Complexity 4609 4604 -5
=============================================
Files 555 555
Lines 36731 36731
Branches 4839 4838 -1
=============================================
- Hits 17750 17725 -25
- Misses 16751 16778 +27
+ Partials 2230 2228 -2
Continue to review full report at Codecov.
|
store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
Outdated
Show resolved
Hide resolved
63834e9
to
7f5715e
Compare
store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
Outdated
Show resolved
Hide resolved
7f5715e
to
bb01183
Compare
Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
bb01183
to
acc3f34
Compare
I hope to fix ISSUE #3473 based on this version to avoid merge conflicts. Please review this pr for me, thanks! @ShannonDing |
…he#3287) Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
…he#3287) Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
…he#3287) Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
What is the purpose of the change
#3286
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.