Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3290] Test case testProcessRequest_RegisterBrokerLogicalQueue bug fix #3291

Merged
merged 5 commits into from
Aug 27, 2021
Merged

[ISSUE #3290] Test case testProcessRequest_RegisterBrokerLogicalQueue bug fix #3291

merged 5 commits into from
Aug 27, 2021

Conversation

odbozhou
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#3290

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.086% when pulling e2ae3fd on odbozhou:5.0.0-preview-unitcasebugfix into 0617f46 on apache:5.0.0-preview.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #3291 (5648699) into 5.0.0-preview (0617f46) will increase coverage by 2.68%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             5.0.0-preview    #3291      +/-   ##
===================================================
+ Coverage            44.00%   46.68%   +2.68%     
- Complexity            3886     4952    +1066     
===================================================
  Files                  525      610      +85     
  Lines                34093    41966    +7873     
  Branches              4647     5757    +1110     
===================================================
+ Hits                 15002    19592    +4590     
- Misses               16970    19719    +2749     
- Partials              2121     2655     +534     
Impacted Files Coverage Δ
...ketmq/logappender/log4j/RocketmqLog4jAppender.java 40.35% <0.00%> (-10.53%) ⬇️
...va/org/apache/rocketmq/logging/inner/Appender.java 32.58% <0.00%> (-4.50%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...tmq/logappender/log4j2/RocketmqLog4j2Appender.java 35.00% <0.00%> (-1.67%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.61% <0.00%> (-1.39%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 50.45% <0.00%> (-1.32%) ⬇️
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 59.18% <0.00%> (-1.03%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 47.24% <0.00%> (-0.87%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.44% <0.00%> (-0.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 42.20% <0.00%> (-0.21%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0617f46...5648699. Read the comment docs.

@RongtongJin RongtongJin merged commit 0f6b5a3 into apache:5.0.0-preview Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants