Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example_Batch.md #3304

Merged
merged 1 commit into from Sep 24, 2021
Merged

Update Example_Batch.md #3304

merged 1 commit into from Sep 24, 2021

Conversation

Silverados
Copy link
Contributor

message.getBody() return byte[], so change to length.

Trivial changes~

Make sure set the target branch to develop

What is the purpose of the change

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

message.getBody() return byte[], so change to length.
@codecov-commenter
Copy link

Codecov Report

Merging #3304 (4bfa004) into develop (fb8bc64) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3304      +/-   ##
=============================================
- Coverage      47.98%   47.97%   -0.02%     
+ Complexity      4562     4334     -228     
=============================================
  Files            552      514      -38     
  Lines          36521    34989    -1532     
  Branches        4818     4665     -153     
=============================================
- Hits           17525    16785     -740     
+ Misses         16781    16019     -762     
+ Partials        2215     2185      -30     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-4.45%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 77.72% <0.00%> (-1.49%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 29.50% <0.00%> (-0.66%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 40.23% <0.00%> (-0.40%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 70.95% <0.00%> (-0.34%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.11% <0.00%> (-0.13%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8bc64...4bfa004. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 54.154% when pulling 4bfa004 on Silverados:patch-2 into 2cac866 on apache:develop.

Copy link
Member

@yuz10 yuz10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you change 2 other places in the document?

image

@yuz10 yuz10 merged commit fa935e8 into apache:develop Sep 24, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
message.getBody() return byte[], so change to length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants