Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3384] Add SendBack message to SCHEDULE_TOPIC_XXXX stats #3385

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

Git-Yang
Copy link
Member

What is the purpose of the change

#3384

Brief changelog

  • Add SendBack message to SCHEDULE_TOPIC_XXXX stats

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 54.503% when pulling f5229b4 on Git-Yang:develop_stats_v2 into daf1b9d on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3385 (f5229b4) into develop (daf1b9d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3385      +/-   ##
=============================================
+ Coverage      48.22%   48.24%   +0.01%     
- Complexity      4603     4605       +2     
=============================================
  Files            555      555              
  Lines          36751    36756       +5     
  Branches        4840     4841       +1     
=============================================
+ Hits           17725    17732       +7     
+ Misses         16796    16790       -6     
- Partials        2230     2234       +4     
Impacted Files Coverage Δ
...ocketmq/broker/processor/SendMessageProcessor.java 39.69% <0.00%> (-0.52%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 29.50% <0.00%> (-0.66%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.23% <0.00%> (-0.37%) ⬇️
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 59.06% <0.00%> (+0.46%) ⬆️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 40.23% <0.00%> (+0.78%) ⬆️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.00% <0.00%> (+1.47%) ⬆️
...rocketmq/client/impl/factory/MQClientInstance.java 51.11% <0.00%> (+1.48%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf1b9d...f5229b4. Read the comment docs.

@odbozhou odbozhou added this to the 4.9.2 milestone Sep 27, 2021
@odbozhou odbozhou merged commit c6a4b82 into apache:develop Sep 27, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants