Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3467] Fail fast on loading files with error mappedFileSize #3466

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Jason918
Copy link
Contributor

@Jason918 Jason918 commented Nov 7, 2021

Make sure set the target branch to develop

What is the purpose of the change

Just revert the merge error with previous commits in #3357

Brief changelog

Revert 2 lines in org.apache.rocketmq.store.MappedFileQueue#doLoad

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Jason918
Copy link
Contributor Author

Jason918 commented Nov 7, 2021

@duhengforever @RongtongJin @yuz10 PTAL

@duhenglucky duhenglucky added this to the 4.9.3 milestone Nov 8, 2021
@RongtongJin RongtongJin changed the title Fail fast on loading files with error mappedFileSize [ISSUE #3467] Fail fast on loading files with error mappedFileSize Nov 8, 2021
@RongtongJin RongtongJin merged commit 7b05208 into apache:develop Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants