-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCKETMQ-42] Output is not friendly, when Main failed. #35
Conversation
…readability of the output
Sync from official RocketMQ repo.
* master: Update code style. Add javadoc to DefaultMQPushConsumer Add javadoc to DefaultMQProducer Add javadoc to DefaultMQProducer
Whether the pull request be merged or not, the project team should close it without anything. Using a commit to close, only comment on "won't fix", seem not regular for outside contributors. More communications should stay on GitHub, rather than your inside team, as least have a discussion, and then have a conclusion. In Apache Software Foundation, This is only a suggestion, but I think this is important. btw @vongosling @WillemJiang |
Hi @wu-sheng , I am sorry for this rash close~ Actually, as @shroman mentioned in this issue, we also think avoid using Finally, thanks for this suggestion, we will have more discussions in GitHub issue before closing a PR. |
I have known about @shroman 's issue. And I am sure he is right about that log is better than Let's focus on
If codes occur exception between these two lines, certainly be Other changes like this one, this is why I only change these classes, as so many You see, this is also why we need discuss before merge or close. 😊 |
Maybe, we should reopen this pull request, and discuss more details. |
@vongosling, your idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you logging it rather than doing SOP.
I have already explain it before. Generally speaking, |
ref issue: https://issues.apache.org/jira/browse/ROCKETMQ-42