Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 3585] [Part D] improve performance of createUniqID() #3590

Merged
merged 1 commit into from Dec 10, 2021

Conversation

areyouok
Copy link
Contributor

@areyouok areyouok commented Dec 6, 2021

Improve performance of createUniqID().

From 2.41% to 0.42% in flame graph of producer side.

…1% to 0.42% in flame graph of producer side.
@areyouok areyouok linked an issue Dec 6, 2021 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 55.166% when pulling 13d7c22 on areyouok:492_PartD into 4daade3 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3590 (13d7c22) into develop (4daade3) will increase coverage by 0.06%.
The diff coverage is 89.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3590      +/-   ##
=============================================
+ Coverage      48.77%   48.83%   +0.06%     
- Complexity      4645     4649       +4     
=============================================
  Files            555      555              
  Lines          36733    36743      +10     
  Branches        4836     4839       +3     
=============================================
+ Hits           17916    17945      +29     
+ Misses         16568    16546      -22     
- Partials        2249     2252       +3     
Impacted Files Coverage Δ
...rocketmq/common/message/MessageClientIDSetter.java 73.80% <81.81%> (+23.80%) ⬆️
.../main/java/org/apache/rocketmq/common/UtilAll.java 42.23% <100.00%> (+1.47%) ⬆️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.57% <0.00%> (-0.98%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.39% <0.00%> (-0.94%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 39.64% <0.00%> (-0.53%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.44% <0.00%> (-0.13%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 56.23% <0.00%> (+0.19%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daade3...13d7c22. Read the comment docs.

@yuz10 yuz10 merged commit ed258b3 into apache:develop Dec 10, 2021
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance for 4.9.2
5 participants