Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3564] Enclose namesrvAddr in example of mqadmin tool by quotation marks #3592

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

HScarb
Copy link
Contributor

@HScarb HScarb commented Dec 6, 2021

What is the purpose of the change

#3564

Brief changelog

add single quotes for namesrvAddr option example, to avoid command splits caused by semicolons

Verifying this change

image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 55.119% when pulling ab10f35 on HScarb:issue_3564 into 4daade3 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3592 (ab10f35) into develop (87b0be0) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3592      +/-   ##
=============================================
- Coverage      48.75%   48.69%   -0.07%     
+ Complexity      4649     4639      -10     
=============================================
  Files            555      555              
  Lines          36733    36733              
  Branches        4838     4836       -2     
=============================================
- Hits           17911    17886      -25     
- Misses         16576    16599      +23     
- Partials        2246     2248       +2     
Impacted Files Coverage Δ
...tmq/namesrv/processor/DefaultRequestProcessor.java 66.23% <0.00%> (-7.47%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 50.71% <0.00%> (-4.79%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
.../java/org/apache/rocketmq/logging/inner/Level.java 36.00% <0.00%> (-2.00%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.82% <0.00%> (-1.74%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 49.92% <0.00%> (-1.50%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 77.22% <0.00%> (-1.00%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 39.84% <0.00%> (-0.40%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b0be0...ab10f35. Read the comment docs.

@duhenglucky duhenglucky merged commit 4d49551 into apache:develop Dec 7, 2021
@yuz10 yuz10 added this to the 4.9.3 milestone Dec 10, 2021
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants