Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3644] exchange parameters #3647

Merged
merged 1 commit into from Dec 15, 2021
Merged

[ISSUE #3644] exchange parameters #3647

merged 1 commit into from Dec 15, 2021

Conversation

zhaohai666
Copy link
Contributor

Expect value and actual value need to be exchanged in ScheduleMessageServiceTest#testCorrectDelayOffset_whenInit line 69

@Git-Yang Git-Yang changed the title exchange parameters [ISSUE #3644] exchange parameters Dec 15, 2021
@Git-Yang
Copy link
Member

link #3644

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 56.273% when pulling 6eb917e on zhaohai1299002788:exchange_parameters into 4a8263b on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3647 (6eb917e) into develop (4d49551) will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3647      +/-   ##
=============================================
+ Coverage      48.71%   49.72%   +1.01%     
- Complexity      4638     4728      +90     
=============================================
  Files            555      555              
  Lines          36733    36770      +37     
  Branches        4836     4847      +11     
=============================================
+ Hits           17893    18284     +391     
+ Misses         16596    16203     -393     
- Partials        2244     2283      +39     
Impacted Files Coverage Δ
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-4.45%) ⬇️
...cketmq/remoting/protocol/RocketMQSerializable.java 86.45% <0.00%> (-3.76%) ⬇️
...pache/rocketmq/store/stats/BrokerStatsManager.java 76.51% <0.00%> (-3.35%) ⬇️
...org/apache/rocketmq/common/message/MessageExt.java 66.66% <0.00%> (-1.57%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...mq/client/consumer/store/LocalFileOffsetStore.java 56.31% <0.00%> (-0.56%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.99% <0.00%> (-0.52%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 74.51% <0.00%> (-0.20%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.18% <0.00%> (-0.01%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d49551...6eb917e. Read the comment docs.

@RongtongJin RongtongJin merged commit 5fea69b into apache:develop Dec 15, 2021
@RongtongJin RongtongJin added this to the 4.9.3 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants