Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3728] docs: Make the 'Uses of keys' entry in the document 'Best practices' more complete. #3729

Merged
merged 1 commit into from Jan 8, 2022

Conversation

XiaoyiPeng
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

For #3728

@coveralls
Copy link

coveralls commented Jan 7, 2022

Coverage Status

Coverage decreased (-0.01%) to 53.122% when pulling ae29fa2 on XiaoyiPeng:docs_uses_of_keys into d564dcd on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #3729 (ae29fa2) into develop (ed5f4e4) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3729      +/-   ##
=============================================
- Coverage      47.29%   47.17%   -0.12%     
+ Complexity      5042     5022      -20     
=============================================
  Files            628      628              
  Lines          41409    41406       -3     
  Branches        5379     5379              
=============================================
- Hits           19584    19533      -51     
- Misses         19395    19452      +57     
+ Partials        2430     2421       -9     
Impacted Files Coverage Δ
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-13.05%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 85.00% <0.00%> (-5.00%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 46.88% <0.00%> (-4.03%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 39.47% <0.00%> (-2.29%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 51.30% <0.00%> (-2.00%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.49%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 43.68% <0.00%> (-0.73%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5f4e4...ae29fa2. Read the comment docs.

@XiaoyiPeng XiaoyiPeng changed the title [ISSUE #3728] docs: Make the The 'Uses of keys' entry in the document 'Best practices' more complete. [ISSUE #3728] docs: Make the 'Uses of keys' entry in the document 'Best practices' more complete. Jan 8, 2022
@duhenglucky duhenglucky merged commit 1ef1af6 into apache:develop Jan 8, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants