Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3733] Upgrade dledger version to 0.2.3 #3734

Merged
merged 1 commit into from Jan 8, 2022

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Upgrade dledger version to 0.2.3

Brief changelog

Upgrade dledger version to 0.2.3

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 53.2% when pulling fb3341a on RongtongJin:upgrade_dledger_version into d564dcd on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3734 (fb3341a) into develop (d564dcd) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3734      +/-   ##
=============================================
+ Coverage      47.16%   47.24%   +0.07%     
- Complexity      5022     5036      +14     
=============================================
  Files            628      628              
  Lines          41406    41406              
  Branches        5379     5379              
=============================================
+ Hits           19531    19563      +32     
+ Misses         19448    19420      -28     
+ Partials        2427     2423       -4     
Impacted Files Coverage Δ
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.69% <0.00%> (-0.38%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (-0.32%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 41.79% <0.00%> (+0.39%) ⬆️
...pl/consumer/ConsumeMessageConcurrentlyService.java 48.05% <0.00%> (+0.48%) ⬆️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 56.43% <0.00%> (+0.49%) ⬆️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 44.40% <0.00%> (+0.72%) ⬆️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (+1.49%) ⬆️
...rocketmq/client/impl/factory/MQClientInstance.java 53.29% <0.00%> (+1.99%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d564dcd...fb3341a. Read the comment docs.

@yuz10 yuz10 linked an issue Jan 8, 2022 that may be closed by this pull request
@yuz10 yuz10 merged commit 938e201 into apache:develop Jan 8, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dledger version to 0.2.3
6 participants