Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3666] fix build error in RIP-28 at getmQclientFactory #3753

Merged

Conversation

ShannonDing
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

fix build error in RIP-28 at getmQclientFactory

Brief changelog

change to getmQclientFactory

Verifying this change

mvn compile -DskipTests

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing
Copy link
Member Author

ShannonDing commented Jan 14, 2022

link #3694 @tianliuliu

@duhenglucky duhenglucky merged commit 2035e6f into apache:develop Jan 14, 2022
@ShannonDing ShannonDing changed the title fix build error in RIP-28 at getmQclientFactory [ISSUE #3666] fix build error in RIP-28 at getmQclientFactory Jan 14, 2022
@ShannonDing ShannonDing added this to the 4.9.3 milestone Jan 17, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants