[ISSUE #3779] Add hook to execute after consume for pop #3780
Conversation
|
@cserwen please pay attention to the CI build error. |
cserwen
force-pushed
the
pop-hook
branch
2 times, most recently
from
4144014
to
8891aaf
Compare
Codecov Report
@@ Coverage Diff @@
## 5.0.0-alpha #3780 +/- ##
=================================================
+ Coverage 46.53% 46.94% +0.40%
+ Complexity 5333 3842 -1491
=================================================
Files 641 495 -146
Lines 44345 32705 -11640
Branches 6116 4534 -1582
=================================================
- Hits 20637 15353 -5284
+ Misses 20982 15317 -5665
+ Partials 2726 2035 -691 Continue to review full report at Codecov.
|
| @@ -457,6 +457,12 @@ public void run() { | |||
| consumeMessageContext.getProps().put(MixAll.CONSUME_CONTEXT_TYPE, returnType.name()); | |||
| } | |||
|
|
|||
| if (ConsumeMessagePopConcurrentlyService.this.defaultMQPushConsumerImpl.hasHook()) { | |||
There was a problem hiding this comment.
The condition is the same to previous branch, it would be better to combine them.
There was a problem hiding this comment.
@caigy OK, I will combine them.
RongtongJin
force-pushed
the
5.0.0-alpha
branch
from
5254805
to
0b4adb4
Compare
|
@cserwen this pr contains many already merged prs, u can rebase to ur branch firstly. |
|
@lizhiboo Ok, I will rebase it. |
Make sure set the target branch to
developWhat is the purpose of the change
#3779
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.