Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3794] add DefaultMQPullConsumer document specification #3796

Merged
merged 1 commit into from Jan 26, 2022

Conversation

Kvicii
Copy link
Contributor

@Kvicii Kvicii commented Jan 25, 2022

If there is no explanation, you need to explicitly specify the replacement class

If there is no explanation, you need to explicitly specify the replacement class
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 51.129% when pulling 4ff2e60 on Kvicii:ISSUE_3794 into 8fdfb42 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3796 (4ff2e60) into develop (8fdfb42) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3796      +/-   ##
=============================================
- Coverage      47.09%   47.05%   -0.04%     
+ Complexity      4877     4873       -4     
=============================================
  Files            636      636              
  Lines          42453    42453              
  Branches        5549     5549              
=============================================
- Hits           19992    19978      -14     
- Misses         19960    19970      +10     
- Partials        2501     2505       +4     
Impacted Files Coverage Δ
...ocketmq/client/consumer/DefaultMQPullConsumer.java 33.33% <ø> (ø)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-7.15%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 41.79% <0.00%> (-0.79%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.28% <0.00%> (-0.67%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 60.55% <0.00%> (-0.46%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.73% <0.00%> (-0.25%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...a/org/apache/rocketmq/store/StoreStatsService.java 29.31% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdfb42...4ff2e60. Read the comment docs.

@duhenglucky duhenglucky merged commit 493c91a into apache:develop Jan 26, 2022
@duhenglucky duhenglucky added this to the 4.9.3 milestone Jan 26, 2022
@francisoliverlee francisoliverlee changed the title DefaultMQPullConsumer document specification [ISSUE #3794] add DefaultMQPullConsumer document specification Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
If there is no explanation, you need to explicitly specify the replacement class

Co-authored-by: Kvicii <Karonazaba@gmail.com>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
If there is no explanation, you need to explicitly specify the replacement class

Co-authored-by: Kvicii <Karonazaba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants