Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3852]Move the Logappender module to external #3851

Merged
merged 2 commits into from Feb 16, 2022

Conversation

duhenglucky
Copy link
Contributor

What is the purpose of the change

Based on the discussion and vote result of separate logappender repo, move logappender the to rocketmq-external repo.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky linked an issue Feb 15, 2022 that may be closed by this pull request
@duhenglucky duhenglucky changed the title Move the Logappender module to external [ISSUE ##3852]Move the Logappender module to external Feb 15, 2022
@duhenglucky duhenglucky added this to the 4.9.3 milestone Feb 15, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 51.355% when pulling fa62032 on duhenglucky:logappender into 48e8c19 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3851 (fa62032) into develop (48e8c19) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3851      +/-   ##
=============================================
- Coverage      47.37%   47.29%   -0.08%     
+ Complexity      4916     4873      -43     
=============================================
  Files            636      632       -4     
  Lines          42481    42276     -205     
  Branches        5561     5544      -17     
=============================================
- Hits           20124    19996     -128     
+ Misses         19856    19784      -72     
+ Partials        2501     2496       -5     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-2.98%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.17% <0.00%> (-2.29%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 50.07% <0.00%> (-1.22%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.82% <0.00%> (-0.72%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 29.31% <0.00%> (-0.66%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e8c19...fa62032. Read the comment docs.

@RongtongJin RongtongJin merged commit a45c7bc into apache:develop Feb 16, 2022
@francisoliverlee francisoliverlee changed the title [ISSUE ##3852]Move the Logappender module to external [ISSUE #3852]Move the Logappender module to external Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the Logappender module to external
6 participants