New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3852]Move the Logappender module to external #3851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duhenglucky
changed the title
Move the Logappender module to external
[ISSUE ##3852]Move the Logappender module to external
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## develop #3851 +/- ##
=============================================
- Coverage 47.37% 47.29% -0.08%
+ Complexity 4916 4873 -43
=============================================
Files 636 632 -4
Lines 42481 42276 -205
Branches 5561 5544 -17
=============================================
- Hits 20124 19996 -128
+ Misses 19856 19784 -72
+ Partials 2501 2496 -5
Continue to review full report at Codecov.
|
yuz10
approved these changes
Feb 15, 2022
panzhi33
approved these changes
Feb 16, 2022
RongtongJin
approved these changes
Feb 16, 2022
francisoliverlee
changed the title
[ISSUE ##3852]Move the Logappender module to external
[ISSUE #3852]Move the Logappender module to external
Feb 21, 2022
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
* feat(logappender) move logappender to external(https://lists.apache.org/thread/938sjby3hnnzcttpp20p17ywhc0rgr8s) * remove logappender module
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* feat(logappender) move logappender to external(https://lists.apache.org/thread/938sjby3hnnzcttpp20p17ywhc0rgr8s) * remove logappender module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Based on the discussion and vote result of separate logappender repo, move logappender the to rocketmq-external repo.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.