[#3903] Add topic validation, forbid sending message to system topic #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cserwen
reviewed
Mar 1, 2022
| @@ -60,6 +60,7 @@ public static void checkMessage(Message msg, DefaultMQProducer defaultMQProducer | |||
| // topic | |||
| Validators.checkTopic(msg.getTopic()); | |||
| Validators.isNotAllowedSendTopic(msg.getTopic()); | |||
| Validators.isSystemTopic(msg.getTopic()); | |||
There was a problem hiding this comment.
This may affect the sending of trace messages.
There was a problem hiding this comment.
You are right! The topic RMQ_SYS_TRACE_TOPIC should be excluded.
…should be excluded.
Codecov Report
@@ Coverage Diff @@
## develop #3904 +/- ##
=============================================
+ Coverage 47.45% 47.53% +0.07%
- Complexity 4922 4934 +12
=============================================
Files 633 633
Lines 42498 42520 +22
Branches 5579 5582 +3
=============================================
+ Hits 20166 20210 +44
+ Misses 19826 19805 -21
+ Partials 2506 2505 -1
Continue to review full report at Codecov.
|
caigy
approved these changes
Mar 1, 2022
HScarb
approved these changes
Mar 1, 2022
ni-ze
approved these changes
Mar 2, 2022
panzhi33
approved these changes
Mar 2, 2022
cserwen
approved these changes
Mar 2, 2022
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
…topic (apache#3904) * Forbid sending message to system topic. * Forbid sending message to system topic.The topic RMQ_SYS_TRACE_TOPIC should be excluded.
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…topic (apache#3904) * Forbid sending message to system topic. * Forbid sending message to system topic.The topic RMQ_SYS_TRACE_TOPIC should be excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
#3903
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.