Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some docs error #3926

Merged
merged 2 commits into from
Mar 4, 2022
Merged

fix some docs error #3926

merged 2 commits into from
Mar 4, 2022

Conversation

Hen1ng
Copy link
Contributor

@Hen1ng Hen1ng commented Mar 3, 2022

Make sure set the target branch to develop

What is the purpose of the change

There are some spell error in cn docs, fix them.

Brief changelog

fix some cn docs eror

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3926 (105d8ce) into develop (19f99a5) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3926      +/-   ##
=============================================
- Coverage      47.55%   47.42%   -0.14%     
+ Complexity      4939     4926      -13     
=============================================
  Files            633      633              
  Lines          42560    42572      +12     
  Branches        5588     5590       +2     
=============================================
- Hits           20241    20190      -51     
- Misses         19809    19868      +59     
- Partials        2510     2514       +4     
Impacted Files Coverage Δ
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.88% <100.00%> (-0.47%) ⬇️
.../broker/subscription/SubscriptionGroupManager.java 64.70% <0.00%> (-16.48%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.17% <0.00%> (-2.29%) ⬇️
...pache/rocketmq/store/MultiPathMappedFileQueue.java 92.30% <0.00%> (-1.93%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 57.34% <0.00%> (-1.90%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.41% <0.00%> (-1.69%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f99a5...105d8ce. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.637% when pulling 105d8ce on Hen1ng:fix_some_docs_error into 5ae4a10 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.637% when pulling 105d8ce on Hen1ng:fix_some_docs_error into 5ae4a10 on apache:develop.

@duhenglucky duhenglucky merged commit 5270053 into apache:develop Mar 4, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* fix some docs error

* remove useless code

Co-authored-by: hening <ninghe.hn@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants