Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3955] delete useless check #3956

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ferrirW
Copy link
Contributor

@ferrirW ferrirW commented Mar 10, 2022

Just delete useless check in SendMessageProcessor.preSend()

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #3956 (14710c9) into develop (7a5d937) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3956      +/-   ##
=============================================
- Coverage      47.64%   47.60%   -0.04%     
+ Complexity      4957     4954       -3     
=============================================
  Files            633      633              
  Lines          42577    42575       -2     
  Branches        5589     5588       -1     
=============================================
- Hits           20285    20269      -16     
- Misses         19786    19797      +11     
- Partials        2506     2509       +3     
Impacted Files Coverage Δ
...ocketmq/broker/processor/SendMessageProcessor.java 39.79% <ø> (+0.19%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-13.05%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-2.98%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5d937...14710c9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 51.666% when pulling 14710c9 on ferrirW:code-format-polish into 446b76b on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 51.666% when pulling 14710c9 on ferrirW:code-format-polish into 446b76b on apache:develop.

@Git-Yang Git-Yang merged commit adbf3db into apache:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants