Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] RemotingCommandException is not thrown in a method #4030

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[Minor] RemotingCommandException is not thrown in a method #4030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ private RemotingCommand getTopicsByCluster(ChannelHandlerContext ctx,
}

private RemotingCommand getSystemTopicListFromNs(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
RemotingCommand request) {
final RemotingCommand response = RemotingCommand.createResponseCommand(null);

TopicList systemTopicList = this.namesrvController.getRouteInfoManager().getSystemTopicList();
Expand All @@ -501,7 +501,7 @@ private RemotingCommand getSystemTopicListFromNs(ChannelHandlerContext ctx,
}

private RemotingCommand getUnitTopicList(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
RemotingCommand request) {
final RemotingCommand response = RemotingCommand.createResponseCommand(null);

TopicList unitTopics = this.namesrvController.getRouteInfoManager().getUnitTopics();
Expand All @@ -514,7 +514,7 @@ private RemotingCommand getUnitTopicList(ChannelHandlerContext ctx,
}

private RemotingCommand getHasUnitSubTopicList(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
RemotingCommand request) {
final RemotingCommand response = RemotingCommand.createResponseCommand(null);

TopicList hasUnitSubTopicList = this.namesrvController.getRouteInfoManager().getHasUnitSubTopicList();
Expand All @@ -526,8 +526,7 @@ private RemotingCommand getHasUnitSubTopicList(ChannelHandlerContext ctx,
return response;
}

private RemotingCommand getHasUnitSubUnUnitTopicList(ChannelHandlerContext ctx, RemotingCommand request)
throws RemotingCommandException {
private RemotingCommand getHasUnitSubUnUnitTopicList(ChannelHandlerContext ctx, RemotingCommand request) {
final RemotingCommand response = RemotingCommand.createResponseCommand(null);

TopicList hasUnitSubUnUnitTopicList = this.namesrvController.getRouteInfoManager().getHasUnitSubUnUnitTopicList();
Expand Down